Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxslt: add patch for CVE-2019-18197 #73161

Closed
wants to merge 1 commit into from
Closed

libxslt: add patch for CVE-2019-18197 #73161

wants to merge 1 commit into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 10, 2019

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-18197

Why patch instead of bumping to the newly available 1.1.34? Because it appears to be a little broken: https://gitlab.gnome.org/GNOME/libxslt/issues/22

So this will have to do for now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
libxslt: add patch for CVE-2019-18197
3ba611f 
rather than just bumping to 1.1.34 because it appears to be a little
broken: https://gitlab.gnome.org/GNOME/libxslt/issues/22
@ofborg ofborg bot requested a review from edolstra November 10, 2019 13:41
@risicle
Copy link
Contributor Author

risicle commented Nov 10, 2019

I have been informed that libxml2 2.9.10 has indeed been released - so I should probably close this in favour of a simultaneous bump.

@risicle risicle closed this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@risicle