Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.qrcode: Fix "No module named pkg_resources" error #73159

Merged
merged 1 commit into from Nov 10, 2019
Merged

pythonPackages.qrcode: Fix "No module named pkg_resources" error #73159

merged 1 commit into from Nov 10, 2019

Conversation

maralorn
Copy link
Member

Motivation for this change

Right now qr will throw:

Traceback (most recent call last):
  File "/nix/store/1avr62jc76yjcsm6v0960mffxl7972a4-python2.7-qrcode-6.1/bin/.qr-wrapped", line 11, in <module>
    sys.exit(main())
  File "/nix/store/1avr62jc76yjcsm6v0960mffxl7972a4-python2.7-qrcode-6.1/lib/python2.7/site-packages/qrcode/console_scripts.py", line 36, in main
    from pkg_resources import get_distribution
ImportError: No module named pkg_resources

This fixes this by adding the setup-tools dependency.

Things done
  • Tested build and execution on x86_64_linux
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn maralorn mentioned this pull request Nov 10, 2019
Merged
@mweinelt
Copy link
Member

Yep, that looks better, also needs to be backported to 19.09.

@worldofpeace worldofpeace merged commit 027e2a2 into NixOS:master Nov 10, 2019
@maralorn maralorn deleted the fix-qrcode branch November 11, 2019 00:25
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 11, 2019
@jluttine jluttine mentioned this pull request Jan 16, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maralorn @mweinelt @jonringer @worldofpeace