Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.sddm: port to python #73136

Merged
merged 1 commit into from Nov 10, 2019
Merged

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Nov 9, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor Author

cc @tfc @marijanp

@mmahut
Copy link
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test sddm

@worldofpeace worldofpeace merged commit ea28846 into NixOS:master Nov 10, 2019
@worldofpeace worldofpeace deleted the port-sddm-test branch November 10, 2019 23:06
@worldofpeace
Copy link
Contributor Author

Ahh, this was failing. Here was the fix needed cf74d29.

Aside from that issue, we all assumed this was fine as ofborg reported the test succeded, but after further investigation the log doesn't exist and it simply reports a success

@grahamc I have noticed this occasionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants