Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.plasma5: port to python #73134

Merged
merged 2 commits into from Nov 25, 2019
Merged

nixosTests.plasma5: port to python #73134

merged 2 commits into from Nov 25, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

#72828

Note, a known issue with this test is the desktop doesn't actually get drawn or the panel before it exits.
This is problematic, and wait_for_window actually doesn't check if it's visible or not, so the desktop being broken visually isn't part of the tests coverage. Not sure if there's an API with plasma to check if everything is initialized and stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor Author

cc @tfc @marijanp

tfc
tfc reviewed Nov 9, 2019
View reviewed changes
nixos/tests/plasma5.nix Outdated Show resolved Hide resolved
@tfc tfc mentioned this pull request Nov 11, 2019
Closed
@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg test plasma5

worldofpeace referenced this pull request Nov 25, 2019
@globin
nixos/tests: fail on failing subtests
ba03a1b 
This was the behaviour in the perl test driver too and a regression.

Also cleaned up unused imports
@worldofpeace
nixosTests.plasma5: drop sddm ocr theme
e4962aa 
OCR in this test has been disabled.
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Nov 25, 2019 •
edited

@GrahamcOfBorg test plasma5

@worldofpeace
Copy link
Contributor Author

Uhh, kernel rebuild. This succeeded for me locally anyways.

@worldofpeace worldofpeace merged commit 1dd140f into NixOS:master Nov 25, 2019
@worldofpeace worldofpeace deleted the port-plasma5-test branch November 25, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc left review comments

@marijanp marijanp marijanp left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel

@flokli flokli Awaiting requested review from flokli

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @tfc @flokli @marijanp