Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/systemd: Allow unit options to have multiple equal defs #73024

Merged
merged 1 commit into from Nov 8, 2019
Merged

nixos/systemd: Allow unit options to have multiple equal defs #73024

merged 1 commit into from Nov 8, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

E.g. this allows

  systemd.services.<name?>.serviceConfig.DynamicUser =
    mkMerge [ true true ];

Ping @srhb

Related is #65380

Things done
  • Made sure this actually works by instantiating a NixOS system with above config

@infinisil
nixos/systemd: Allow unit options to have multiple equal defs
821651e 
E.g. this allows

  systemd.services.<name?>.serviceConfig.DynamicUser =
    mkMerge [ true true ];
@zimbatm zimbatm merged commit 9fe4e06 into NixOS:master Nov 8, 2019
@infinisil infinisil deleted the system-unit-options-equal branch November 8, 2019 19:40
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
@infinisil @dtzWill
nixos/systemd: Allow unit options to have multiple equal defs (NixOS#…
37f3456 
…73024)

E.g. this allows

  systemd.services.<name?>.serviceConfig.DynamicUser =
    mkMerge [ true true ];

(cherry picked from commit 9fe4e06)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @zimbatm