Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dedf6ded5a32
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6783fdd561b0
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 3, 2019

  1. nixos/gnome3: add sound-theme-freedesktop 

    I've noticed a similar issue in Pantheon, without this
sound theme installed there's no system sounds.
I believe it's because the gnome theme and the pantheon
theme inherit this one.
    @worldofpeace
    worldofpeace committed Nov 3, 2019
    Copy the full SHA
    4bdbbc1 View commit details

  2. nixos/xdg/sounds: add sound-theme-freedesktop

    @worldofpeace
    worldofpeace committed Nov 3, 2019
    Copy the full SHA
    4e2161f View commit details

Commits on Nov 9, 2019

  1. Merge pull request #71416 from worldofpeace/gnome3-sound-theme 

    nixos/gnome3: add sound-theme-freedesktop
    @worldofpeace
    worldofpeace authored Nov 9, 2019
    Copy the full SHA
    6783fdd View commit details
Showing with 11 additions and 1 deletion.
  1. +5 −1 nixos/modules/config/xdg/sounds.nix
  2. +6 −0 nixos/modules/services/x11/desktop-managers/gnome3.nix
6 changes: 5 additions & 1 deletion nixos/modules/config/xdg/sounds.nix
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ config, lib, ... }:
{ config, lib, pkgs, ... }:

with lib;
{
@@ -14,6 +14,10 @@ with lib;
};

config = mkIf config.xdg.sounds.enable {
environment.systemPackages = [
pkgs.sound-theme-freedesktop
];

environment.pathsToLink = [
"/share/sounds"
];
6 changes: 6 additions & 0 deletions nixos/modules/services/x11/desktop-managers/gnome3.nix
View file
Original file line number Diff line number Diff line change
@@ -217,6 +217,12 @@ in

services.xserver.updateDbusEnvironment = true;

# gnome has a custom alert theme but it still
# inherits from the freedesktop theme.
environment.systemPackages = with pkgs; [
sound-theme-freedesktop
];

# Needed for themes and backgrounds
environment.pathsToLink = [
"/share" # TODO: https://github.com/NixOS/nixpkgs/issues/47173