Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mu version from unreleased to stable (revert to 1.2) #73067

Merged
merged 1 commit into from Nov 8, 2019
Merged

Fix mu version from unreleased to stable (revert to 1.2) #73067

merged 1 commit into from Nov 8, 2019

Conversation

yurkobb
Copy link
Contributor

@yurkobb yurkobb commented Nov 8, 2019

Motivation for this change

This reverts commits 53a536c
and af931c1.

The repology.org info was incorrect, pulling in a development version
of mu as a release. The current (stable) release of mu is still 1.2:
https://github.com/djcb/mu/releases

I have also reported this on repology.org:
https://repology.org/project/mu/report

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ryantm

@yurkobb
Revert "mu: 1.2 -> 1.3.3"
b220d3e 
This reverts commits 53a536c
and af931c1.

The repology.org info was incorrect, pulling in a development version
of mu as a release. The current (stable) release of mu is still 1.2:
https://github.com/djcb/mu/releases
@ofborg ofborg bot requested review from the-kenny and peterhoeg November 8, 2019 18:31
@ryantm ryantm merged commit 54b0476 into NixOS:master Nov 8, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/mu-4e-doesnt-work-anymore-after-nixos-unstable-update/4743/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yurkobb @nixos-discourse @ryantm