Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

picat: 1.9 -> 2.7 #73068

Closed
wants to merge 1 commit into from
Closed

picat: 1.9 -> 2.7 #73068

wants to merge 1 commit into from

Conversation

klntsky
Copy link
Member

@klntsky klntsky commented Nov 8, 2019

Motivation for this change

Version bump.

Haven't tested on darwin, though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @earldouglas

@ofborg ofborg bot requested a review from earldouglas November 8, 2019 18:52
@jonringer
Copy link
Contributor

@GrahamcOfBorg build picat

jonringer
jonringer reviewed Nov 9, 2019
View reviewed changes
pkgs/development/compilers/picat/default.nix

stdenv.mkDerivation {
name = "picat-1.9-4";
gcc7Stdenv.mkDerivation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this to all-packages.nix, and just do:

  package = callPackage ../../../.nix {
    stdenv = gcc7Stdenv;
  };
Suggested change
gcc7Stdenv.mkDerivation {
stdenv.mkDerivation {

pkgs/development/compilers/picat/default.nix
@@ -1,27 +1,29 @@
{ stdenv, fetchurl }:
{ stdenv, fetchurl, zlib, gcc7Stdenv }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, fetchurl, zlib, gcc7Stdenv }:
{ stdenv, fetchurl, zlib }:

pkgs/development/compilers/picat/default.nix

src = fetchurl {
url = http://picat-lang.org/download/picat19_src.tar.gz;
sha256 = "0wvl95gf4pjs93632g4wi0mw1glzzhjp9g4xg93ll2zxggbxibli";
url = http://picat-lang.org/download/picat27b12_src.tar.gz;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow for bot to update package

Suggested change
url = http://picat-lang.org/download/picat27b12_src.tar.gz;
url = http://picat-lang.org/download/picat${stdenv.lib.replaceStrings ["."] [""] version}_src.tar.gz;

pkgs/development/compilers/picat/default.nix
'';

installPhase = ''
mkdir -p $out/bin
cp picat_$ARCH $out/bin/picat
cp picat $out/bin/picat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can replace both lines with:

Suggested change
cp picat $out/bin/picat
install -D m755 picat -t $out/bin/picat

jonringer
jonringer reviewed Nov 9, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, need to edit meta.platforms to be platforms.unix; for it to attempt to build darwin

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@tomberek
Copy link
Contributor

tomberek commented Sep 7, 2020

Picat is now at 2.8-2 in master. Closing as OBE.

@tomberek tomberek closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@earldouglas earldouglas earldouglas approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@klntsky @jonringer @tomberek @earldouglas @alyssais