nixos/users:added users.allowLoginless option #73082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
reviewed
Nov 8, 2019
| @@ -72,6 +72,7 @@ with lib; | |||
| (mkRemovedOptionModule [ "security" "setuidPrograms" ] "Use security.wrappers instead") | |||
|
|
|||
| (mkRenamedOptionModule [ "security" "virtualization" "flushL1DataCache" ] [ "security" "virtualisation" "flushL1DataCache" ]) | |||
| (mkRenamedOptionModule ["security" "initialRootPassword"] ["users" "users" "root" "initialHashedPassword"]) | |||
There was a problem hiding this comment.
please add this to nixos/modules/config/users-groups.nix instead, like done in other places - we intend to move away from a global rename.nix.
flokli
requested changes
Nov 8, 2019
| @@ -6,13 +6,13 @@ | |||
| stdenv.mkDerivation rec { | |||
|
|
|||
| pname = "home-manager"; | |||
| version = "2019-10-23"; | |||
| version = "2019-10-29"; | |||
There was a problem hiding this comment.
this probably isn't related, and should go in a separate PR ;-)
|
Closed in favor of #73106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #73003
Also made security.initialRootPassword a renamed option
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @