Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm_9: disable failing tests on 32-bit ARM #73083

Merged
merged 2 commits into from Nov 13, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Some of LLVM 9's tests fail on armv7l. LLVM 7 has a similar set of tests that fail on 32-bit ARM.

I manually ran the tests and copied the errors, in case someone wants to debug this further or submit a fix upstream:

convert-debugloc.ll:69:19: error: DW4-CHECK-NEXT: expected string not found in input
; DW4-CHECK-NEXT: 0x00000000: Compile Unit: length = 0x0000007a version = 0x0004 abbr_offset = 0x0000 addr_size = 0x08 (next unit at 0x0000007e)
                  ^
<stdin>:4:1: note: scanning from here
0x00000000: Compile Unit: length = 0x00000064 version = 0x0005 unit_type = DW_UT_compile abbr_offset = 0x0000 addr_size = 0x08 (next unit at 0x00000068)
^
convert-inlined.ll:32:19: error: DW5-CHECK-NEXT: expected string not found in input
; DW5-CHECK-NEXT: DW_AT_location (DW_OP_addrx 0x0, DW_OP_deref, DW_OP_convert (0x0000001e) "DW_ATE_signed_8", DW_OP_convert (0x00000022) "DW_ATE_signed_32", DW_OP_stack_value)
                  ^
<stdin>:31:2: note: scanning from here
 DW_AT_location (DW_OP_addrx 0x0, DW_OP_deref, DW_OP_convert (0xbef12c10) "DW_ATE_signed_8", DW_OP_convert (0x00000000) "DW_ATE_signed_32", DW_OP_stack_value)
 ^
convert-linked.ll:9:10: error: CHECK: expected string not found in input
; CHECK: DW_OP_convert ([[CU0BT0]]) "DW_ATE_signed_8", DW_OP_convert ([[CU0BT1]]) "DW_ATE_signed_32"
         ^
<stdin>:46:2: note: scanning from here
 DW_AT_location (DW_OP_breg5 RDI+0, DW_OP_constu 0xff, DW_OP_and, DW_OP_convert (0xb6a18aba) "DW_ATE_signed_8", DW_OP_convert (0x00000000) "DW_ATE_signed_32", DW_OP_stack_value)
 ^
<stdin>:46:2: note: with "CU0BT0" equal to "0x00000023"
 DW_AT_location (DW_OP_breg5 RDI+0, DW_OP_constu 0xff, DW_OP_and, DW_OP_convert (0xb6a18aba) "DW_ATE_signed_8", DW_OP_convert (0x00000000) "DW_ATE_signed_32", DW_OP_stack_value)
 ^
<stdin>:46:2: note: with "CU0BT1" equal to "0x00000027"
 DW_AT_location (DW_OP_breg5 RDI+0, DW_OP_constu 0xff, DW_OP_and, DW_OP_convert (0xb6a18aba) "DW_ATE_signed_8", DW_OP_convert (0x00000000) "DW_ATE_signed_32", DW_OP_stack_value)
 ^
<stdin>:46:83: note: possible intended match here
 DW_AT_location (DW_OP_breg5 RDI+0, DW_OP_constu 0xff, DW_OP_and, DW_OP_convert (0xb6a18aba) "DW_ATE_signed_8", DW_OP_convert (0x00000000) "DW_ATE_signed_32", DW_OP_stack_value)
                                                                                  ^
op-convert.test:26:13: error: CHECK-NEXT: expected string not found in input
CHECK-NEXT: [0x0000000000001000, 0x0000000000001002): DW_OP_breg5 RDI+0, DW_OP_constu 0xffffffff, DW_OP_and, DW_OP_convert (0x0000002a) "DW_ATE_signed_8", DW_OP_convert (0x00000031) "DW_ATE_signed_32", DW_OP_stack_value
            ^
<stdin>:46:18: note: scanning from here
 DW_AT_location (0x00000036
                 ^
<stdin>:47:2: note: possible intended match here
 [0x0000000000001000, 0x0000000000001002): DW_OP_breg5 RDI+0, DW_OP_constu 0xffffffff, DW_OP_and, DW_OP_convert (0xb6a28aba) "DW_ATE_signed_8", DW_OP_convert (0xbe8bf588) "DW_ATE_signed_32", DW_OP_stack_value
 ^
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323 @7c6f434c @dtzWill

@lopsided98
Copy link
Contributor Author

lopsided98 commented Nov 9, 2019

I added a commit that disables the frem.ll test on armv6l, like in #73084, because I tested LLVM 9 and found it had the same issue as LLVM 7.

@matthewbauer matthewbauer merged commit 56c309f into NixOS:master Nov 13, 2019
@lopsided98 lopsided98 deleted the llvm-9-arm branch November 25, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants