Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 3928e7f6b1d5
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 3022fde292ea
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 31, 2019

  1. nixos/dnsdist: Add CAP_NET_BIND_SERVICE to AmbientCapabilities

    It seems that dnsdist doesn't actually request CAP_NET_BIND_SERVICE, which is why normally it's executed and root and setuids to another, unprivileged, user. This means that as it is, dnsdist will be unable to bind to any port under 1024 and will fail with access denied.
    
    Removing CAP_SETGID and CAP_SETUID is also related to this as we don't actually change the uid or gid after the fact as we use DynamicUser. (That part isn't strictly NEEDED but there's no reason to have those capabilities if we don't use them).
    
    There are also some additional sandboxing we can remove from the service definition as they are assumed true or strict by DynamicUser: specifically PrivateTmp and ProtectSystem respectively.
    
    ProtectHome is still there, despite being assumed read-only as setting it to true means they are seen as empty. I don't think it really matters as I don't know if systemd will ignore it or not, but I didn't see any reason to go hunting for excuses to make it a bigger change.
    ShaRose committed Oct 31, 2019
    Copy the full SHA
    9e2308e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. Merge pull request #71576 from ShaRose/patch-1

    nixos/dnsdist: Add CAP_NET_BIND_SERVICE to AmbientCapabilities
    infinisil committed Nov 8, 2019
    Copy the full SHA
    3022fde View commit details
    Browse the repository at this point in the history