Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.03] varnish6: add patch for CVE-2019-15892 #73078

Merged
merged 1 commit into from Nov 8, 2019
Merged

[r19.03] varnish6: add patch for CVE-2019-15892 #73078

merged 1 commit into from Nov 8, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 8, 2019 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2019-15892

Fixed for 19.09 in #70532

No point release for 6.1, so borrowing patch from debian.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from garbas and fpletz November 8, 2019 22:14
redvers
redvers approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@redvers redvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked the other versions and branches via: https://nvd.nist.gov/vuln/detail/CVE-2019-15892

Release 19.09

4.1.10 (good)
5.2.1 (good)
6.2.1 (good)

Release 19.03

4.1.10 (good)
5.2.1 (good)
6.1.1 (VULN - what this PR addresses)

master

6.0.5 (good)
6.2.2 (good)
6.3.1 (good)

On varnish's release page https://varnish-cache.org/releases/index.html they list:

6.3.1
6.2.2
6.0.5

"All releases not mentioned above are End-Of-Life and unsupported"

This is the reason there is no point release and why @risicle needed to pull the debian patch.

Looks good to me.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/66

@infinisil infinisil merged commit 675884f into NixOS:release-19.03 Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redvers redvers redvers approved these changes

@garbas garbas Awaiting requested review from garbas

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @nixos-discourse @redvers @infinisil