New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coqPackages.InteractionTrees: init at 1.0.0 #73075
Conversation
74b00e7
to
96c8833
Compare
96c8833
to
9503f35
Compare
If you package too many versions of a library, the configuration space may blow up. Most configurations are thus untested and quality of the package set decreases. It is hard to fix InteractionTrees to make it compatible with latest coq-ext-lib? According to the changelog (https://github.com/coq-community/coq-ext-lib/releases/tag/v0.10.3), there are no breaking changes in that version… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version of InteractionTrees (d408b9151f7f77d1ab0b8a0f2d57f210e16206ae) builds fine with paco and coq-ext-lib that are available in nixpkgs.
Yeah, I noticed it builds against coq-ext-lib 0.10.3, but the author of InteractionTrees warned against it, because they define some notation at level 60: whereas coq-ext-lib changed said notation to level 61: The following script:
fails with:
which is why I agree about removing the excess versions of all packages, but I think w.r.t. this issue we can either:
|
Thanks for clarifying the issue. Do we need to package two versions of InteractionTrees or one is enough? In which case, which version? |
I think we can just package 1.0.0, and I'll possibly add a more recent version when they have a less complex dependency story. I'll change this PR to reflect this. |
@vbgl do you have any input on when to phase out support for older Coq versions? |
When maintaining them becomes a pain… |
Thank you for your contributions.
|
Still important to me, I'll update the PR hopefully in the near future! |
Closed by #118134. |
This package required a bit of refactoring, I would love for someone to double-check and comment on that.
InteractionTrees
has only one release, version 1.0.0. It dates from a while back, so I wanted to package both it, and a more recent version pointing at the current master branch.Sadly, those have pretty different requirements on
paco
andcoq-ext-lib
. In particular, while I recently madecoq-ext-lib
be at version 0.10.3 for recent Coq versions, they supposedly have made a breaking change as far as InteractionTrees is concerned between 0.10.2 and 0.10.3.So
InteractionTrees_20191104
wantscoq-ext-lib=0.10.2
, which meant I had to make that available. In order to get that flexibility, I have parameterizedInteractionTrees
over builders forpaco
andcoq-ext-lib
(see incoq-packages.nix
). I'm not sure that this is the way to go, so feedback on this would be appreciated.