Thank you for your suggestions! I have pushed most of them.

How have you tested this program?

I manually ran the rasdaemon and ras-mc-ctl programs with every command line option, and checked that they seemed to run successfully.

There are tests under TESTING in rasdaemon's README (https://github.com/mchehab/rasdaemon/blob/v0.6.4/README) that should probably be in nixos/tests, but I have not added them.

Are these tests required? (I believe the similar mcelog package is not tested either).
If these tests are required, should the contrib scripts install to a split dev output? Should the mce-inject/mce-test/aer-inject programs be separated into their own packages?

Why not get it on pagure? There they already have version 0.6.4-2

• Pagure does not have any release tarballs: https://releases.pagure.org/rasdaemon
• The latest commit on the main repository
  (http://git.infradead.org/users/mchehab/rasdaemon.git) is 0.6.4.
  The tag debian/0.6.4-2 on pagure just changes debian packaging files.

Another alternative to consider would be to use the github release, since the official tarball from infradead does not contain the contrib folder mentioned in the TESTING section.

Use | instead of / for the sed delimiter. Then you don't need so much escaping :)

Sed delimiter replacement only applies to the 's' command. :(
(http://www.gnu.org/software/sed/manual/sed.html#The-_0022s_0022-Command)

i've had a go at cleaning this up a bit here
(i'm not sure it's a good practice to have maintainer-list.nix entry authored by someone that is not the maintainer being added but this should be a separate commit)
handling /etc/ras/dimm_labels.d with the module is a bit tricky without expected content so i've left that as a TODO
maybe we can find someone with a supported Dell machine for that?
testing the module would probably require compiling a custom kernel and packaging of the error injection tools, that's probably worth it, but a bit more work/research than i'm currently willing to put in

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

i'm closing this as my #85039 is based on this and if not improved, at least more up to date

@leocp1 feel free to reopen this, help out with my PR, or let me know if you'd like to be added as a maintainer on that

and thanks for providing a solid start