so, i realized that this fails with error: unsupported version 6.8.3 for plugin ingest-attachment since i rebased it onto master from 19.03... but all of the plugins have the same version for 6.8.3, so they're all broken since 3ab433d. shall i fix them in this pull request?

edit: they're also broken for elasticsearch 7 due to the same version mismatch issue. does nobody use elasticsearch plugins?

I'm not sure who uses them, I was using them when I was still using es on nixos. Can you please update them, looks like someone forgot to update plugins when updating es? Can you also please add comment to elasticsearch that plugins needs to be updated when updating package?

no problem. i'll also remove the 5.x versions since elasticsearch 5.x has been removed. also, i noticed that some of the plugins use pkgs.fetchurl instead of fetchurl directly so i'll change those.

i've pushed some style fixups and stuff as well. if a reviewer wants those split out of this pr i'd be happy to do so.

looks good to me lgtm

Btw @ashkitten have you tested this with nixos module with latest elasticsearch? Does it work well?

i've tested it with default elasticsearch and it works for my use case, at least.