New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodePackages.typescript-language-server: add typescript dependency #73119
Conversation
This looks good to me! (Works on my macOS machine.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stumbled upon this after wondering why typescript-language-server didn't work like it should. Adding typescript
as an installed package worked too - although this is obviously a much better solution.
b6eb9c8
to
1b5ebc9
Compare
Please rework your PR. It now has a merge conflict after PR #89184 has been merged |
typescript-language-server is a wrapper around tsserver and is useless without it
1b5ebc9
to
d845152
Compare
@prusnak I just force pushed a change to bring it up-to-date. |
Just wondering would a local tsserver installation still override the default one with these changes? |
@felschr No, right now it wouldn't. But I could update |
PR got combined with a few other node updates. Closing so that the update goes trough smoothly. |
…back Make possible to use a different typescript version. If there is already a typescript binary on your PATH, probably you want to use that. This way it's possible to use a different typescript version (with nix shell, direnv, npm, ...), but still have a fallback version, so the lsp server doesn't fail to start Related to NixOS#73119
Motivation for this change
typescript-language-server is a wrapper around tsserver and is useless without it.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @malob