Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php74: init at 7.4.0 #73151

Closed
wants to merge 8 commits into from
Closed

php74: init at 7.4.0 #73151

wants to merge 8 commits into from

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Nov 10, 2019 •
edited

Motivation for this change

Issue - #72780

To correct build phpPackages need this PR - #73908

Changes in this PR:

  • Drop support build php wint maraidb connector-c. Php not support version 3.1.
  • Remove unused configure flags. The configureFlags+ option is not applied during build.
  • Add option config.php.pear
  • Add option config.php.ipv6
  • Add php v7.4 RC6
  • Build PHP with an external GD library
  • Update preConfigure phase. Needed for a correct build from git-source.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 10, 2019

cc @etu @aanderse @shyim

@ofborg ofborg bot requested review from globin and etu November 10, 2019 08:21
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 10, 2019

@GrahamcOfBorg build php74

jtojnar
jtojnar reviewed Nov 10, 2019
View reviewed changes
pkgs/development/interpreters/php/default.nix Outdated Show resolved Hide resolved
pkgs/development/interpreters/php/default.nix Show resolved Hide resolved
pkgs/development/interpreters/php/default.nix Outdated Show resolved Hide resolved
pkgs/development/interpreters/php/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from jtojnar November 10, 2019 14:56
@jtojnar
Copy link
Contributor

jtojnar commented Nov 10, 2019

@GrahamcOfBorg build php74

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 10, 2019

@GrahamcOfBorg build php72 php73 php74

@etu etu mentioned this pull request Nov 21, 2019
Merged
10 tasks
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 22, 2019

@GrahamcOfBorg build php72 php73 php74

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

@GrahamcOfBorg build php72 php73 php74

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

@GrahamcOfBorg build php72Packages.apcu php72Packages.apcu_bc php72Packages.ast php72Packages.box php72Packages.composer php72Packages.couchbase php72Packages.event php72Packages.igbinary php72Packages.imagick php72Packages.mailparse php72Packages.memcached php72Packages.mongodb php72Packages.pcov php72Packages.pcs php72Packages.pdo_sqlsrv php72Packages.php-cs-fixer php72Packages.php-parallel-lint php72Packages.phpcbf php72Packages.phpcs php72Packages.phpstan php72Packages.pinba php72Packages.protobuf php72Packages.psalm php72Packages.psysh php72Packages.pthreads php72Packages.redis php72Packages.sqlsrv php72Packages.xdebug php72Packages.yaml php72Packages.zmq

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

@GrahamcOfBorg build php73Packages.apcu php73Packages.apcu_bc php73Packages.ast php73Packages.box php73Packages.composer php73Packages.couchbase php73Packages.event php73Packages.igbinary php73Packages.imagick php73Packages.mailparse php73Packages.memcached php73Packages.mongodb php73Packages.pcov php73Packages.pcs php73Packages.pdo_sqlsrv php73Packages.php-cs-fixer php73Packages.php-parallel-lint php73Packages.phpcbf php73Packages.phpcs php73Packages.phpstan php73Packages.pinba php73Packages.protobuf php73Packages.psalm php73Packages.psysh php73Packages.pthreads php73Packages.redis php73Packages.sqlsrv php73Packages.xdebug php73Packages.yaml

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

@GrahamcOfBorg build php74Packages.ast php74Packages.box php74Packages.composer php74Packages.event php74Packages.igbinary php74Packages.imagick php74Packages.mailparse php74Packages.memcached php74Packages.mongodb php74Packages.pcov php74Packages.pdo_sqlsrv php74Packages.php-cs-fixer php74Packages.php-parallel-lint php74Packages.phpcbf php74Packages.phpcs php74Packages.phpstan php74Packages.pinba php74Packages.psalm php74Packages.psysh php74Packages.pthreads php74Packages.redis php74Packages.sqlsrv php74Packages.xdebug php74Packages.yaml

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

@GrahamcOfBorg build php74Packagescouchbase. php74Packages.pcs php74Packages.pdo_sqlsrv php74Packages.protobuf php74Packages.sqlsrv php74Packages.zmq

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 25, 2019

cc @etu @aanderse - please recheck PR.

@Izorkin Izorkin changed the title php74: init at 7.4 RC6 php74: init at 7.4,0 Nov 27, 2019
@Izorkin Izorkin changed the title php74: init at 7.4,0 php74: init at 7.4.0 Nov 27, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 5, 2019

@etu rebased PR to apply others updates?

@etu
Copy link
Contributor

etu commented Dec 5, 2019

@Izorkin The reason my PR was picked over this one is because mine was easier to test because it didn't affect older versions. It only pushed the new version in without causing rebuilds of the older versions.

But if you want to do the refactorings to add new options and things I think that would belong in a new PR rather than rebasing this due to the obvious conflicts that has appeared.

Also: inclusion of a flag for disabling ipv6 is something I don't see the point in doing, if you don't want ipv6 in your life you can disable it on an operating system level.

@etu etu closed this Dec 5, 2019
@Izorkin Izorkin deleted the php74 branch December 10, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyim shyim shyim left review comments

@aragon999 aragon999 aragon999 left review comments

@javaguirre javaguirre Awaiting requested review from javaguirre

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@jtojnar jtojnar Awaiting requested review from jtojnar jtojnar is a code owner

@globin globin Awaiting requested review from globin globin is a code owner

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Izorkin @jtojnar @etu @globin @shyim @aragon999