python3Packages.dictances: init at 1.5.0 #73079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pamplemousse
changed the title
Pamplemousse
force-pushed
the
distances
branch
from
3c2aab1
to
82c6d64
Compare
Pamplemousse
changed the title
jonringer
reviewed
Nov 8, 2019
Pamplemousse
force-pushed
the
distances
branch
from
82c6d64
to
f812aad
Compare
risicle
reviewed
Nov 9, 2019
Pamplemousse
force-pushed
the
distances
branch
from
f812aad
to
071766c
Compare
jonringer
reviewed
Nov 13, 2019
| }; | ||
|
|
||
| # Missing some nixpkgs | ||
| doCheck = false; |
There was a problem hiding this comment.
I would still like to see some tests, they are really important to demonstrate that a package isn't broken when it's dependencies get bumped.... although I guess this package doesn't really have any direct dependencies :)
Still would be nice :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make this package is available.
Things done
sandboxinnix.confon non-NixOS linux)./result/bin/)nix path-info -Sbefore and after)