Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployAndroidPackage: prefer local builds #73130

Merged
merged 1 commit into from Nov 16, 2019

Conversation

jameysharp
Copy link
Contributor

Motivation for this change

These derivations just unzip something and maybe do a little patching, so there's no benefit to sending the zip file off to a build server and then downloading the unzipped results again.

Things done

I've just done minimal testing that nix-build still works; I really hope changing preferLocalBuilds doesn't affect behavior of the built package or anything that depends on it 馃槄

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

These derivations just unzip something and maybe do a little patching,
so there's no benefit to sending the zip file off to a build server and
then downloading the unzipped results again.
@tadfisher
Copy link
Contributor

Note to self: do this in https://github.com/tadfisher/android-nixpkgs

@bjornfor bjornfor merged commit 5d1c9ce into NixOS:master Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants