New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tests to python #73131
Port tests to python #73131
Conversation
@GrahamcOfBorg test roundcube |
This looks like a pretty straight forward and mechanical conversion. I spotted no issues. |
nixos/tests/roundcube.nix
Outdated
@@ -21,7 +21,7 @@ import ./make-test-python.nix ({ pkgs, ...} : { | |||
}; | |||
|
|||
testScript = '' | |||
roundcube.start | |||
roundcube.start() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good catch... 👍
Should I drop the tests that are failing on arm or is this good to go? |
@1000101 did these fail on arm previously, too? Can you rebase on latest master? |
Jackett and hibernate have been failing on arm before (source: hydra). Rebased! |
@GrahamcOfBorg test roundcube |
This is a bit hard to merge, can this be broken down to individual PRs? |
Ok, it was mostly the roundcube fix already fixed in e292be7. Dropped that commit and rebased on master. |
Built and succeeded running all updated tests locally (x86_64), merging. |
Thanks a million!!! |
Motivation for this change
#72828
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @