Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/podman: support configuring registries and policy [WIP] #68343

Closed
wants to merge 2 commits into from
Closed

nixos/podman: support configuring registries and policy [WIP] #68343

wants to merge 2 commits into from

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Needed a way to configure podman registries and policy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@gebner
Copy link
Member

gebner commented Sep 11, 2019

How does this compare to #54925? This PR seems much simpler. Does podman work for you? Are there any missing features here?

@peterhoeg
Copy link
Member Author

That PR uses raw text for the config - here we take an attrset and turn that into JSON. podman does work here for my basic use cases. The only real thing pending that I'm aware of is proper rootless supports but we to wait for various component updates for that.

@peterhoeg peterhoeg changed the title nixos/podman: support configuring registries and policy nixos/podman: support configuring registries and policy [WIP] Sep 11, 2019
@disassembler disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020
@adisbladis adisbladis mentioned this pull request Apr 20, 2020
Merged
10 tasks
@adisbladis
Copy link
Member

This podman module was merged #85604.

@adisbladis adisbladis closed this Apr 24, 2020
@peterhoeg peterhoeg deleted the m/podman branch April 25, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterhoeg @gebner @adisbladis @lheckemann @disassembler