Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ociTools: fixing outdated documentation #68345

Merged
merged 1 commit into from Sep 9, 2019
Merged

ociTools: fixing outdated documentation #68345

merged 1 commit into from Sep 9, 2019

Conversation

spacekookie
Copy link
Member

The documentation was out of date because of last-minute changes to
the ociTools API. This should probably be backported to stable to
not confuse everybody ;)

(I guess that means I also PR to staging-next?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @alyssais @edef1c

@spacekookie spacekookie mentioned this pull request Sep 9, 2019
Closed
10 tasks
@worldofpeace
Copy link
Contributor

worldofpeace commented Sep 9, 2019 •
edited

Branch off hasn't happened yet so there isn't a 19.09 branch yet for

Did you mean 19.03 possibly?
(branch off happens on master as well)

Otherwise this should be fine for master.

@spacekookie
Copy link
Member Author

spacekookie commented Sep 9, 2019 via email

@worldofpeace
Copy link
Contributor

Oh, I thought branchoff for 19.09 had happened on the weekend. Disregard the other PR in this case

It was intended but has been delayed to happen today 🤞️

@worldofpeace worldofpeace merged commit 0428567 into NixOS:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spacekookie @worldofpeace