Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swift: 5.0.2 -> 5.0.3 #68346

Closed
wants to merge 1 commit into from
Closed

swift: 5.0.2 -> 5.0.3 #68346

wants to merge 1 commit into from

Conversation

mroi
Copy link
Contributor

@mroi mroi commented Sep 9, 2019 •
edited

Trivial update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill

@ofborg ofborg bot requested a review from dtzWill September 9, 2019 08:59
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@mroi mroi mentioned this pull request Oct 27, 2019
Merged
10 tasks
tomfitzhenry
tomfitzhenry approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@tomfitzhenry tomfitzhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mroi
Copy link
Contributor Author

mroi commented Jan 17, 2020

Superseded by #72120.

@mroi mroi closed this Jan 17, 2020
@mroi mroi deleted the patch-1 branch January 17, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomfitzhenry tomfitzhenry tomfitzhenry approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mroi @tomfitzhenry @lheckemann