[webnfc] Support read/write external type records #18926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 9, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1791533
branch
3 times, most recently
from
289dec5
to
b9459c8
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1791533
branch
from
b9459c8
to
c435205
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1791533
branch
3 times, most recently
from
e3983e9
to
323fcbe
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1791533
branch
from
323fcbe
to
82b1bd1
Compare
Note: not support sub-records yet. The corresponding spec changes: w3c/web-nfc#278 w3c/web-nfc#326 and the relevant issue: w3c/web-nfc#331 BUG=520391,995234 Change-Id: I5b99543bddf505975567ecad22c0d5390842337f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791533 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#705377}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1791533
branch
from
82b1bd1
to
682b7af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: not support sub-records yet.
The corresponding spec changes:
w3c/web-nfc#278
w3c/web-nfc#326
and the relevant issue:
w3c/web-nfc#331
BUG=520391,995234
Change-Id: I5b99543bddf505975567ecad22c0d5390842337f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791533
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#705377}