Google cloud sdk pythonenv #68348
Merged
Google cloud sdk pythonenv #68348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might have been there as a transitive dependency but better be explicity about it.
Previously only direct dependencies were available in the python search path. Transitive dependencies would not be available and thus a few features would not work due to import errors. Those import errors were being caugth and gave a (wrong) hint why it wouldn't work. By using `python.withPackages` instead of the crafted search path with only the direct dependencies those missing feature should now be working. See issue NixOS#67094 for details on the observed errors. Fixes NixOS#67094
FRidh
requested changes
Sep 9, 2019
|
I've cherry-picked the openssl change to staging. |
|
Creating signed URLs with gsutil works for me now with the changes in this PR. Thank you! I did not observer any regressions so far. |
It is not a python module just an application using/based on python.
|
Any chance this might get merged soon? It would be really helpful, the package as it is currently released is unfortunately broken and of limited use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Previously only direct dependencies were available in the python search
path. Transitive dependencies would not be available and thus a few
features would not work due to import errors. Those import errors were
being caugth and gave a (wrong) hint why it wouldn't work. By using
python.withPackagesinstead of the crafted search path with only thedirect dependencies those missing feature should now be working.
See issue #67094 for details on the observed errors.
I only verified that the command now doesn't complain about the missing pyopenssl. Maybe @toraritte or @red-hood could give it a try?
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @