Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] trigger push workflows on push to master only #18924

Merged
merged 1 commit into from Sep 10, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 9, 2019

These are being triggered on pushes to all branches now, including
epochs/* and triggers/* branches. That's not useful.

These are being triggered on pushes to all branches now, including
epochs/* and triggers/* branches. That's not useful.
@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip
Copy link
Member Author

foolip commented Sep 9, 2019

@jgraham can you review? Perhaps it's an intended side effect that some of the steps get run on PRs for branches in this repo, and that most changes that could break this are from such PRs? If so we should run these on PRs too. I'd like to think that's not necessary for at least the manifest workflow, but... opinions?

@foolip foolip merged commit 8d867f8 into master Sep 10, 2019
@foolip foolip deleted the foolip/github-actions-push-master branch September 10, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants