Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tigervnc: add perl to buildInputs #75367

Conversation

itsHMR
Copy link
Contributor

@itsHMR itsHMR commented Dec 9, 2019

tigervnc ships vncserver, a wrapper script which makes starting Xvnc more convenient and its written in perl

Motivation for this change

make vncserver wrapper script usable

Things done

add perl to buildInputs

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

tigervnc ships vncserver, quote from the documentation:
vncserver - a wrapper script which makes starting Xvnc more convenient vncserver requires Perl.
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 75367

1 package were build:
  • tigervnc

vncserver runs

@c0bw3b c0bw3b merged commit a46e3eb into NixOS:master Dec 14, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 14, 2019

Hello @itsHMR and welcome around here since it is your first PR

CONTRIBUTING.md gives advices as to the format of commit messages we expect.

clayrat pushed a commit to clayrat/nixpkgs that referenced this pull request Dec 14, 2019
tigervnc ships vncserver, quote from the documentation:
vncserver - a wrapper script which makes starting Xvnc more convenient vncserver requires Perl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants