Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: add useOzone and 'chromiumOzone' variant #61008

Closed
wants to merge 1 commit into from
Closed

chromium: add useOzone and 'chromiumOzone' variant #61008

wants to merge 1 commit into from

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented May 5, 2019 •
edited

Motivation for this change

Since I did this, apparently talked about it on HN, and someone asked in IRC, I figured I'd send this.

This adds a new chromium variant that enables Ozone and builds relevant ozone backends.

Last time I built it, it wasn't really usable due to where upstream is at with Wayland support. Furthermore, the HiDPI handling is pretty completely broken still.

NOTE: I could use some advice on how to instruct Hydra to not build this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Jun 12, 2019

@colemickens This is a replacement for #50486?

@colemickens
Copy link
Member Author

@gnidorah yes.

@colemickens
Copy link
Member Author

I've not pushed this yet, it's still too buggy to use, but here's a screenshot, it finally is usable on hidpi now (make sure you don't use the gtk theme):
output

@colemickens
Copy link
Member Author

Chromium Ozone is not in a perfect position yet, but we can go ahead and merge this so other folks can use and test, etc.

@colemickens
Copy link
Member Author

cc: @volth can you review this?

colemickens
colemickens commented Sep 12, 2019
View reviewed changes
pkgs/applications/networking/browsers/chromium/common.nix
@@ -21,11 +21,13 @@
# optional dependencies
, libgcrypt ? null # gnomeSupport || cupsSupport
, libva ? null # useVaapi
, libxkbcommon, libdrm, wayland # useOzone
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to ? null all of these too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they are used in the chromiumOzone build they should be not null.

@Mic92
Copy link
Member

Mic92 commented Sep 27, 2019

To disable the hydra build, one need to set meta.hydraPlatforms = [].

@Mic92
Copy link
Member

Mic92 commented Sep 27, 2019

Mhm. I think broke evaluation with my merge:

attribute 'useVaapi' at /home/joerg/.cache/nix-review/pr-61008/nixpkgs/pkgs/applications/networking/browsers/chromium/default.nix:39:14 already defined at /home/joerg/.cache/nix-review/pr-61008/nixpkgs/pkgs/applications/networking/browsers/chromium/default.nix:39:14

@Mic92
Copy link
Member

Mic92 commented Sep 27, 2019

cc @zimbatm as a wayland user.

@zimbatm
Copy link
Member

zimbatm commented Sep 30, 2019 

$ nix-env -f /home/zimbatm/.cache/nix-review/pr-61008/nixpkgs -qaP --xml --out-path --show-trace --meta
error: while evaluating 'callPackageWith' at /home/zimbatm/.cache/nix-review/pr-61008/nixpkgs/lib/customisation.nix:108:35, called from /home/zimbatm/.cache/nix-review/pr-61008/nixpkgs/pkgs/top-level/all-packages.nix:17701:14:
while evaluating 'makeOverridable' at /home/zimbatm/.cache/nix-review/pr-61008/nixpkgs/lib/customisation.nix:67:24, called from /home/zimbatm/.cache/nix-review/pr-61008/nixpkgs/lib/customisation.nix:112:8:
attribute 'useVaapi' at /home/zimbatm/.cache/nix-review/pr-61008/nixpkgs/pkgs/applications/networking/browsers/chromium/default.nix:39:14 already defined at /home/zimbatm/.cache/nix-review/pr-61008/nixpkgs/pkgs/applications/networking/browsers/chromium/default.nix:39:14

@colemickens
Copy link
Member Author

I rebased. It starts building, but I don't have CPU available right now to build. I didn't fix the hydra building part yet.

@colemickens
Copy link
Member Author

Actually, since the Ozone build uses the dev channel, it's already excluded from hydra. Should be okay to review again.

@lukateras lukateras self-assigned this Dec 2, 2019
@colemickens
Copy link
Member Author

Dropping this as I don't plan to pursue it. For now I plan to build my own chromium in nixpkgs-wayland using volth's chromium-git PR.

@colemickens colemickens closed this Dec 9, 2019
@colemickens colemickens deleted the chromium-upstream-ozone branch January 30, 2020 09:36
@wmertens
Copy link
Contributor

@colemickens Is the ozone build somewhat usable? Would you mind pointing me to how I can get a nixpkgs-wayland setup working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees

@lukateras lukateras

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colemickens @Mic92 @zimbatm @wmertens @lukateras