Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera rotation #2393

Merged
merged 13 commits into from
Dec 8, 2019
Merged

Camera rotation #2393

merged 13 commits into from
Dec 8, 2019

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Dec 7, 2019

With this change, the horizontal in map view is the reference plane of the selected plotting frame.
Further, the camera rotates with the plotting frame (in particular, if the camera is looking at a body which is fixed in the plotting frame, the camera is fixed in the plotting frame). This mean that the plotted trajectories do not rotate as time passes, a behaviour which was somewhat confusing and annoying.

Examples below.

legends: ⟨subject⟩, ⟨reference frame⟩ (⟨reference plane⟩)

screenshot25 Earth, ECEF (Earth equator) screenshot24 Earth, ECSA (ecliptic)
screenshot26 Inner planets, ECI (Earth equator) screenshot27 Inner planets, Sun-centred inertial (Sun equator)
screenshot31 Saturnian system, Saturn-centred sun-aligned (Saturn orbit) screenshot32 Saturnian system, Saturn-centred inertial (Saturn equator)
screenshot30 Uranian system, Uranus-centred sun-aligned (Uranus orbit) screenshot29 Uranian system, Uranus-centred inertial (Uranus equator)

@pleroy
Copy link
Member

pleroy commented Dec 7, 2019

retest this please

@@ -137,5 +137,16 @@ void __cdecl principia__SetTargetVessel(Plugin* const plugin,
return m.Return();
}

WXYZ __cdecl principia__CameraReferenceRotation(
Plugin* const plugin) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fits on the previous line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants