Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sailsd: 0.2.0 -> 0.3.0 #72036

Merged
merged 1 commit into from Dec 8, 2019
Merged

sailsd: 0.2.0 -> 0.3.0 #72036

merged 1 commit into from Dec 8, 2019

Conversation

kragniz
Copy link
Member

@kragniz kragniz commented Oct 26, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
Copy link
Contributor

risicle commented Oct 27, 2019

nix-review builds for me, macos 10.13, executable runs.

@kragniz
Copy link
Member Author

kragniz commented Nov 9, 2019

@GrahamcOfBorg build sailsd

1 similar comment
@ckauhaus
Copy link
Contributor

@GrahamcOfBorg build sailsd

@ckauhaus
Copy link
Contributor

... I wonder why ofBorg does not do build the pkg. @grahamc any idea?

Lassulus
Lassulus approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, seems to work

@Lassulus Lassulus merged commit ff4bef8 into NixOS:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kragniz @risicle @ckauhaus @Lassulus