Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethminer: 0.18.0-rc.0 -> 0.18.0 #75400

Merged
merged 4 commits into from Dec 25, 2019
Merged

ethminer: 0.18.0-rc.0 -> 0.18.0 #75400

merged 4 commits into from Dec 25, 2019

Conversation

nand0p
Copy link
Contributor

@nand0p nand0p commented Dec 9, 2019

tested on nixos

@nand0p nand0p changed the title WIP: ethminer v18 WIP: ethminer: 0.18.0-rc.0 -> 0.18.0 Dec 10, 2019
@nand0p nand0p changed the title WIP: ethminer: 0.18.0-rc.0 -> 0.18.0 ethminer: 0.18.0-rc.0 -> 0.18.0 Dec 14, 2019
@nand0p
Copy link
Contributor Author

nand0p commented Dec 19, 2019

@infinisil Hi! I know you merged in the initial PR for this software. Perhaps you have time to review/merge this one? It fixes the currently broken package and module in master.

infinisil
infinisil requested changes Dec 24, 2019
View reviewed changes
nixos/modules/services/misc/ethminer.nix Show resolved Hide resolved
nixos/modules/services/misc/ethminer.nix Show resolved Hide resolved
nixos/modules/services/misc/ethminer.nix Outdated Show resolved Hide resolved
infinisil
infinisil approved these changes Dec 25, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)

@infinisil infinisil merged commit 5dc7050 into NixOS:master Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nand0p @infinisil