-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera rotation #2393
Camera rotation #2393
Conversation
eb0e9ac
to
129ddd6
Compare
retest this please |
Permutation<CameraReference, Navigation> const celestial_mirror( | ||
Permutation<CameraReference, Navigation>::XZY); | ||
auto const result = | ||
OrthogonalMap<WorldSun, World>::Identity() * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Identity
instead of OrthogonalMap
, we might be able to do better checks that way in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then I need to Forget
the identity for composition anyway; it should not be harder to put a static_assert or SFINAE on OrthogonalMap<F, T>::Identity
than on Identity<F, T>
.
With this change, the horizontal in map view is the reference plane of the selected plotting frame.
Further, the camera rotates with the plotting frame (in particular, if the camera is looking at a body which is fixed in the plotting frame, the camera is fixed in the plotting frame). This mean that the plotted trajectories do not rotate as time passes, a behaviour which was somewhat confusing and annoying.
Examples below.
legends: ⟨subject⟩, ⟨reference frame⟩ (⟨reference plane⟩)