Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbfs: don't use store path for fusermount #75303

Merged
merged 1 commit into from Dec 9, 2019
Merged

kbfs: don't use store path for fusermount #75303

merged 1 commit into from Dec 9, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Dec 8, 2019

Motivation for this change

kbfs fails to mount because it tries to use fusermount directly from the store, which does not have the suid bit. Instead it should use the regular wrapper on NixOS, or a native version of fuse that is installed with the default package manager on non-NixOS systems.

Things done

This partially reverts #71287 so kbfsfuse finds fusermount from the default location (which is /run/wrappers/bin/fusermount in case of NixOS).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from ehmry, np and bennofs December 8, 2019 22:34
@tobim
Copy link
Contributor Author

tobim commented Dec 8, 2019

cc @worldofpeace

@worldofpeace
Copy link
Contributor

I actually came upon this recently in #73930.

@srhb
Copy link
Contributor

srhb commented Dec 9, 2019

Confirmed, this fixes kbfs for me

@srhb srhb merged commit 3a6bedb into NixOS:master Dec 9, 2019
@tobim tobim deleted the pkgs/kbfs-fusermount branch December 9, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat8913 mat8913 mat8913 approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@np np Awaiting requested review from np

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobim @worldofpeace @srhb @mat8913