Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: Install bash-completion symlink for gitk #75406

Merged
merged 1 commit into from Dec 11, 2019
Merged

git: Install bash-completion symlink for gitk #75406

merged 1 commit into from Dec 11, 2019

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Dec 10, 2019 •
edited

Motivation for this change

Since bash-completion rules are loaded dynamically, the completion rules for gitk <Tab> were not being loaded until the user first typed git <Tab>. Fix this by adding a symlink named gitk.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti @the-kenny @wmertens @globin

@andersk
git: Install bash-completion symlink for gitk
a16dbef 
Since bash-completion rules are loaded dynamically, the completion
rules for `gitk <Tab>` waere not being loaded until the user first
typed `git <Tab>`.  Fix this by adding a symlink named `gitk`.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
wmertens
wmertens approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 697b44b into NixOS:master Dec 11, 2019
@andersk andersk deleted the gitk-completion branch January 3, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

@peti peti Awaiting requested review from peti

@globin globin Awaiting requested review from globin

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersk @wmertens