Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.owl: 0.7.1 -> 0.7.2 #75192

Merged
merged 1 commit into from Dec 22, 2019
Merged

ocamlPackages.owl: 0.7.1 -> 0.7.2 #75192

merged 1 commit into from Dec 22, 2019

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Dec 8, 2019 •
edited

Motivation for this change

Upgrade and enable tests due to upstream fixes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@bcdarwin
ocamlPackages.owl: 0.7.1 -> 0.7.2
bfe5d1c 
- also enable tests (except on OSX) due to upstream fixes
@marsam marsam merged commit f9cd904 into NixOS:master Dec 22, 2019
@marsam
Copy link
Contributor

marsam commented Dec 22, 2019

Thanks!

@bcdarwin bcdarwin deleted the update-owl branch December 23, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @marsam