Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse: Use postgres service to create database and user #75294

Merged
merged 1 commit into from Dec 14, 2019

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Dec 8, 2019

Motivation for this change

Use the postgresql service for managing database and user creation instead of rolling a custom script.
Depends on #75293

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @Ralith @corngood

@kampka kampka changed the title Postgres service refactor matrix-synapse: Use postgres service to create database and user Dec 8, 2019
@aanderse aanderse requested a review from Ma27 December 9, 2019 01:55
@kampka
Copy link
Contributor Author

kampka commented Dec 13, 2019

Rebased against master with #75293 now merged, so this should now be good to go.

@Ma27 Ma27 requested a review from Ekleog December 14, 2019 14:54
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Ekleog
Copy link
Member

Ekleog commented Dec 14, 2019

@ofborg build nixosTests.matrix-synapse

@kampka
Copy link
Contributor Author

kampka commented Dec 14, 2019

@Ekleog seems like the build has failed but I cannot really see why. Mind having a look?

@Ekleog
Copy link
Member

Ekleog commented Dec 14, 2019

The build didn't actually fail, it's just that AFAIR it's not supported on darwin :) Let's merge, then. Thank you!

@Ekleog Ekleog merged commit 226ea5c into NixOS:master Dec 14, 2019
@Ma27 Ma27 mentioned this pull request Feb 20, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants