Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soulseekqt: fix icons, change unpack method, update homepage, more generic appimage handling #75392

Merged
merged 2 commits into from Mar 11, 2020
Merged

soulseekqt: fix icons, change unpack method, update homepage, more generic appimage handling #75392

merged 2 commits into from Mar 11, 2020

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Dec 9, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@grahamc
Copy link
Member

grahamc commented Dec 9, 2019

Would you mind rewording your commit message to be more descriptive about why these changes are being made?

@bignaux bignaux changed the title soulseekqt: minor changes soulseekqt: fix things incording upstream tarball change, unpack use p7zip instead of binwalk, fix homepage Dec 9, 2019
@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

Like @grahamc wrote, could you describe in your commit message why this is needed. It's far from apparent.

@bignaux bignaux changed the title soulseekqt: fix things incording upstream tarball change, unpack use p7zip instead of binwalk, fix homepage soulseekqt: fix icons, change unpack method, update homepage, more generic appimage handling Feb 29, 2020
@bignaux
Copy link
Contributor Author

bignaux commented Feb 29, 2020

done.

@worldofpeace
Copy link
Contributor

It fails to build

convert: unable to open image `SoulseekQt.png': No such file or directory @ error/blob.c/OpenBlob/2881.
convert: no images defined `/nix/store/f583rkdjbsdx7dbb7p3vf2hglv2nz03v-soulseekqt-2018-1-30/share/icons/hicolor/16x16/apps/SoulseekQt.png' @ error/convert.c/ConvertImageCommand/3235.

@bignaux bignaux force-pushed the soulseekqt branch 2 times, most recently from a96236b to 7e3320c Compare March 1, 2020 16:59
@bignaux
Copy link
Contributor Author

bignaux commented Mar 1, 2020

fix, i did a slight modification by removing patchPhase, i think it's simpler like that.

@flokli flokli merged commit a3dde62 into NixOS:master Mar 11, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 12, 2020
@flokli @dtzWill
Merge pull request NixOS#75392 from bignaux/soulseekqt
692efc2 
soulseekqt: fix icons, change unpack method, update homepage, more generic appimage handling
(cherry picked from commit a3dde62)
@bignaux bignaux deleted the soulseekqt branch October 19, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bignaux @grahamc @FRidh @worldofpeace @flokli