Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autochanger support to bacula-sd #75285

Merged
merged 1 commit into from Dec 11, 2019
Merged

Add autochanger support to bacula-sd #75285

merged 1 commit into from Dec 11, 2019

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Dec 8, 2019

  • Fixing interrupted descriptions
  • Added more verbose descriptions
  • Addded to the descriptions
  • uniformly reformated descriptions to break at 80 chars

(cherry picked from commit c7945c8)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Lassulus

@Lassulus
Copy link
Member

Lassulus commented Dec 8, 2019

ah, the commit message needs to change, sadly I missed that on the other PR

@wucke13
Copy link
Contributor Author

wucke13 commented Dec 8, 2019

Updated this PR. Sorry.

Lassulus
Lassulus approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Edit: can we change the commit message to nixos/bacula-sd: add autochange support

Lassulus
Lassulus requested changes Dec 10, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change the commit message to nixos/bacula-sd: add autochange support

@wucke13
nixos/bacula-sd: add autochange support
73c19cc 
+ Fixing interrupted descriptions
+ Added more verbose descriptions
+ Addded <literal> to the descriptions
+ uniformly reformated descriptions to break at 80 chars

(cherry picked from commit c7945c8)
@wucke13
Copy link
Contributor Author

wucke13 commented Dec 11, 2019

Sure, done.

@Lassulus Lassulus merged commit 93696e3 into NixOS:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wucke13 @Lassulus