Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libnotify: propagate glib and gdk-pixbuf #75344

Merged
merged 2 commits into from Dec 9, 2019
Merged

libnotify: propagate glib and gdk-pixbuf #75344

merged 2 commits into from Dec 9, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

They're in Requires:
Requires: gdk-pixbuf-2.0, gio-2.0 >= 2.26.0, glib-2.0 >= 2.26.0

This has caused one issue so far #75321.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
libnotify: propagate glib and gdk-pixbuf
79d45c4 
They're in Requires:
Requires: gdk-pixbuf-2.0, gio-2.0 >=  2.26.0, glib-2.0 >=  2.26.0

This has caused one issue so far NixOS#75321.
@worldofpeace
libnotify: nixpkgs-fmt, add maintainers
8f2e47e
@ofborg ofborg bot requested review from jtojnar and hedning December 9, 2019 07:31
hedning
hedning approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@hedning hedning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuff in requires should propagated 👍

@jtojnar jtojnar merged commit 4538eea into NixOS:master Dec 9, 2019
@jtojnar jtojnar deleted the libnotify-propagated branch December 9, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @hedning @jtojnar