Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bluez: enable checkPhase on x86_64-linux #75317

Merged
merged 1 commit into from Dec 11, 2019
Merged

bluez: enable checkPhase on x86_64-linux #75317

merged 1 commit into from Dec 11, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Some reports are in #69460 and #74995 (comment) about test failures, but they're all unrelated to NixOS.
This package is meant for Linux, so I don't see a problem with these checks running on our Linux builders.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace mentioned this pull request Dec 9, 2019
Merged
10 tasks
@Moredread
Copy link
Contributor

Moredread commented Dec 9, 2019 •
edited

I saw build failures on Windows WSL in a Debian installation. I'll try to reproduce it. As the package isn't really useful on Windows this is not a huge issue though IMO. Also, the test failure didn't cause the derivation to fail, so it wouldn't impact users in anycase.

@worldofpeace
Copy link
Contributor Author

It seems at least one test case fails on aarch64, I'll limit to x86_64.

@Moredread
Copy link
Contributor

On NixOS it works consistently, so I'm OK with this PR.

@FRidh FRidh added this to Needs review in Staging Dec 10, 2019
@worldofpeace worldofpeace changed the title bluez: enable checkPhase bluez: enable checkPhase on x86_64-linux Dec 11, 2019
@worldofpeace worldofpeace merged commit fb390ed into NixOS:staging Dec 11, 2019
Staging automation moved this from Needs review to Done Dec 11, 2019
@worldofpeace worldofpeace deleted the bluez-docheck branch December 11, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moredread Moredread Moredread approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @Moredread