Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coturn: Support secrets file for configuring the static-auth-secret #75263

Closed
wants to merge 1 commit into from

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Dec 8, 2019

Motivation for this change

This change allows for the coturn shared secret to be stored in a file outside the nix store.
It also makes it easier to publish configurations in public VCS with fewer issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ralith

@ashkitten
Copy link
Contributor

can you rebase this to master please?

@kampka
Copy link
Contributor Author

kampka commented Jun 3, 2020

can you rebase this to master please?

I'm going to close this for now as I haven't any vested interest in it atm.

@kampka kampka closed this Jun 3, 2020
Copy link
Contributor

@MatthewCroughan MatthewCroughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this re-submitted and merged? I see no reason this was left out.

@MatthewCroughan
Copy link
Contributor

I have created a new PR which simply coauthors this commit. Thank you. #129059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants