Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clojure: 1.10.1.489 -> 1.10.1.492 #75351

Merged
merged 1 commit into from Dec 11, 2019
Merged

clojure: 1.10.1.489 -> 1.10.1.492 #75351

merged 1 commit into from Dec 11, 2019

Conversation

jlesquembre
Copy link
Member

Install again default deps.edn. deps.edn was embedded in clojure jar,
but that change was reverted, see
clojure/brew-install@a349695

Update derivation to produce only one output. Multiple outputs was
introduced by #35140, but I don't think is necessary anymore.

Code was automatically formatted with nixpkgs-fmt

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bendlas @yegortimoshenko

@jlesquembre
clojure: 1.10.1.489 -> 1.10.1.492
9bd99ed 
Install again default deps.edn. deps.edn was embedded in clojure jar,
but that change was reverted, see
clojure/brew-install@a349695

Update derivation to produce only one output. Multiple outputs was
introduced by NixOS#35140, but I don't think is necessary anymore.
@bendlas
Copy link
Contributor

bendlas commented Dec 11, 2019

Merging this into a single output LGTM. I think the original change might have been spurious. nix-review shows lumo failing, but thats also the case for master ...

Thanks!

@bendlas bendlas merged commit 44fe29a into NixOS:master Dec 11, 2019
@jlesquembre
Copy link
Member Author

@bendlas thanks for reviewing and merging it!

@jlesquembre jlesquembre deleted the clojure branch December 11, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlesquembre @bendlas