Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpdris2: add missing gdk-pixbuf to buildInputs #75321

Closed
wants to merge 1 commit into from
Closed

mpdris2: add missing gdk-pixbuf to buildInputs #75321

wants to merge 1 commit into from

Conversation

leotaku
Copy link
Contributor

@leotaku leotaku commented Dec 9, 2019

Motivation for this change

In order to properly import Notify from libnotify, gobject-introspection seemingly also needs gdk-pixbuf. Without this change the notification feature of mpDris2 is impaired.

Things done

Added the missing gdk-pixbuf dependency to buildInputs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eonpatapon

worldofpeace
worldofpeace reviewed Dec 9, 2019
View reviewed changes
pkgs/tools/audio/mpdris2/default.nix Outdated
@@ -36,6 +36,7 @@ python3.pkgs.buildPythonApplication rec {
buildInputs = [
glib
libnotify
gdk-pixbuf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add this to the function arguments.

@worldofpeace
Copy link
Contributor

Can you also correct your commit message to your PR title?

@leotaku
Copy link
Contributor Author

leotaku commented Dec 9, 2019

@worldofpeace Sorry, no idea how that slipped through. Don't PR when you are half asleep I suppose.

@worldofpeace
Copy link
Contributor

@worldofpeace Sorry, no idea how that slipped through. Don't PR when you are half asleep I suppose.

I guess we encounter similar situations 😄 (depending on the timezone).
Looks good, could you squash the commits? (with message as per the PR title)

@leotaku
Copy link
Contributor Author

leotaku commented Dec 9, 2019

@worldofpeace I'll do it as soon as I can.

@leotaku
mpdris2: add missing gdk-pixbuf to buildInputs
e884b38 
In order to properly import `Notify` from `libnotify`, `gobject-introspection` seemingly also needs `gdk-pixbuf`.

Also add gdk-pixbuf to function arguments

Restore alphabetical order of buildInputs
@worldofpeace
Copy link
Contributor

Hmm, I think I actually found a deeper issue here.
libnotify has the following packages in Requires

Requires: gdk-pixbuf-2.0, gio-2.0 >=  2.26.0, glib-2.0 >=  2.26.0

We had to add glib and gdk-pixbuf here so we could have those typelibs available, because they're required. I think we should instead add those libs to propagatedBuildInputs, and mpdris2 shouldn't directly depend on gdk-pixbuf because it actually doesn't.

worldofpeace added a commit to worldofpeace/nixpkgs that referenced this pull request Dec 9, 2019
@worldofpeace
libnotify: propagate glib and gdk-pixbuf
79d45c4 
They're in Requires:
Requires: gdk-pixbuf-2.0, gio-2.0 >=  2.26.0, glib-2.0 >=  2.26.0

This has caused one issue so far NixOS#75321.
@worldofpeace worldofpeace mentioned this pull request Dec 9, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leotaku @worldofpeace