Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildSkawarePackage: pass through extra args #75322

Merged
merged 1 commit into from Dec 16, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Dec 9, 2019

Motivation for this change

This allows things like hooks other than postInstall to be passed
through to mkDerivation, which is very useful when customising or
debugging a package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pmahoney

This allows things like hooks other than postInstall to be passed
through to mkDerivation, which is very useful when customising or
debugging a package.
@alyssais alyssais merged commit a506532 into NixOS:master Dec 16, 2019
@alyssais alyssais deleted the buildSkawarePackage-args branch December 16, 2019 13:27
@Profpatsch
Copy link
Member

Not a fan.

@alyssais
Copy link
Member Author

alyssais commented Dec 22, 2019 via email

@Profpatsch
Copy link
Member

What do you propose instead?

Thinking about it, maybe it’s the best way

@alyssais
Copy link
Member Author

alyssais commented Dec 22, 2019 via email

@Profpatsch
Copy link
Member

I think I’m gonna revert this, because if you are debugging you can just add the extra argument to buildSkawarePackage proper or use overrideDerivation to add it after the fact.

e.g. outputs wasn’t added and meta has strange semantics now.

@Profpatsch
Copy link
Member

reverted as part of #83162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants