Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mbedtls_1_3, alienfx, coprthr, firestr #75310

Merged
merged 4 commits into from Dec 9, 2019
Merged

Remove mbedtls_1_3, alienfx, coprthr, firestr #75310

merged 4 commits into from Dec 9, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Dec 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
mbedtls_1_3: remove EoL version
d04d1c6
@c0bw3b
alienfx: remove package
f85826a 
Upstream is gone
@c0bw3b
coprthr: remove package
fdffba3 
It's been marked as broken for 5 years
@c0bw3b
firestr: remove package
35b21d1 
It's been marked as broken for 4 years
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation Dec 8, 2019
@c0bw3b c0bw3b moved this from To do to In progress in Picking up garbage Dec 8, 2019
tomberek
tomberek approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. I like the idea of cleaning up old/broken packages. I'll approve the alienfx portion.

@fpletz fpletz merged commit 8bad6c4 into NixOS:master Dec 9, 2019
Picking up garbage automation moved this from In progress to Done Dec 9, 2019
@c0bw3b c0bw3b deleted the rem/mbed13-alienfx-coprthr-firestr branch December 9, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@fpletz fpletz fpletz approved these changes

@tomberek tomberek tomberek approved these changes

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
6.topic: hygiene 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@c0bw3b @fpletz @tomberek @ehmry @worldofpeace