Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechat: 2.6 -> 2.7 #75307

Merged
merged 1 commit into from Dec 10, 2019
Merged

weechat: 2.6 -> 2.7 #75307

merged 1 commit into from Dec 10, 2019

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 8, 2019 •
edited

Motivation for this change

New upstream release. https://weechat.org/files/changelog/ChangeLog-2.7.html

I disabled support for PHP and Javascript, both of which are now apparently enabled by default.

  • Javascript depends on a v8 version <= 3.24.3, and while we have 3.14 in nixpkgs it is only used by a single package and probably on the way out. Upstream issue is here: Javascript plugin does not compile with v8 version 3.30.33.16 weechat/weechat#360
  • PHP wants a bunch of additional dependencies, that would somewhat increase the footprint of the derivation 
    [100%] Linking C shared module php.so
[100%] Linking C shared module guile.so
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lc-client
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lzip
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lzip
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -largon2
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lsodium
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lreadline
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lpq
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lsqlite3
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lpq
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lldap
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -llber
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lpam
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -lpng
/nix/store/a0kdlyvbj9j4l67a8kxjr494qx6g3q0v-binutils-2.31.1/bin/ld: cannot find -ljpeg
collect2: error: ld returned 1 exit status
make[2]: *** [src/plugins/php/CMakeFiles/php.dir/build.make:101: src/plugins/php/php.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:1239: src/plugins/php/CMakeFiles/php.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323 @the-kenny @lheckemann @Ma27

@mweinelt
weechat: 2.6 -> 2.7
d1cb8bf 
Disables support for Javascript and PHP:
- Javascript requires an old version of v8
- PHP requires a larger number of dependencies in addition to php-embed

Changelog [1]:

  New features
    - core: add option weechat.look.nick_color_hash_salt to shuffle nick colors (issue NixOS#635)
    - core: add different icons sizes (16x16 to 512x512) (issue NixOS#1347)
    - core: add file weechat.desktop
    - core: add reverse of string for screen in evaluation of expressions with "revscr:"
    - core: add length of string (number of chars and on screen) in evaluation of expressions with "length:xxx" and "lengthscr:xxx"
    - core: add calculation of expression in evaluation of expressions with "calc:xxx" (issue NixOS#997)
    - core: add optional default path (evaluated) in completion "filename"
    - core: add support of modifiers in evaluation of expressions with "modifier:name,data,string"
    - api: add modifier "color_encode_ansi" (issue NixOS#528)
    - api: add modifier "eval_path_home"
    - irc: add filters on raw buffer (issue NixOS#1000)
    - irc: add option irc.look.display_pv_warning_address to display a warning in private buffer if the remote nick address has changed (issue NixOS#892)
    - irc: add server option "ssl_password" (issue NixOS#115, issue NixOS#1416)
    - irc: add "user" in output of irc_message_parse (issue NixOS#136)
    - irc: add options irc.color.message_kick and irc.color.reason_kick (issue NixOS#683, issue NixOS#684)
    - logger: add option logger.file.color_lines (issue NixOS#528, issue NixOS#621)
    - script: add options "-ol" and "-il" in command "/script list" to send translated string with list of scripts loaded, display "No scripts loaded" if no scripts are loaded
    - xfer: add option xfer.file.download_temporary_suffix with default value ".part" (issue NixOS#1237)

  Bug fixes
    - core: set buffer name, short name and title only if the value has changed
    - core: fix scrolling up in bare mode when switched to bare mode at the top of the buffer (issue NixOS#899, issue NixOS#978)
    - core: optimize load of configuration files
    - core: fix window separators not respecting window splits (issue NixOS#630)
    - core: fix cursor mode info when prefix_align is none and with words split across lines (issue NixOS#610, issue NixOS#617, issue NixOS#619)
    - core: add support of reverse video in ANSI color codes
    - core: fixed segfault during excessive evaluation in function string_repeat (issue NixOS#1400)
    - buflist: fix extra spaces between buffers when conditions are used to hide buffers (regression introduced in version 2.6) (issue NixOS#1403)
    - irc: do not automatically open a channel with name "0" (issue NixOS#1429)
    - irc: remove option irc.network.channel_encode, add server option "charset_message" to control which part of the IRC message is decoded/encoded to the target charset (issue NixOS#832)
    - irc: use path from option xfer.file.upload_path to complete filename in command "/dcc send" (issue NixOS#60)
    - logger: fix write in log file if it has been deleted or renamed (issue NixOS#123)
    - python: send "bytes" instead of "str" to callbacks in Python 3 when the string is not UTF-8 valid (issue NixOS#1389)
    - relay: send message "_buffer_title_changed" to clients only when the title is changed
    - xfer: fix memory leak when a xfer is freed and when the plugin is unloaded

  Tests
    - unit: add tests on GUI color functions

  Build
    - core: fix build on Haiku (issue NixOS#1420)
    - core: fix build on Alpine
    - core: remove file FindTCL.cmake
    - core: display an error on missing dependency in CMake (issue NixOS#916, issue NixOS#956)
    - debian: disable Javascript plugin on Debian Sid and Ubuntu Eoan
    - debian: build with Guile 2.2
    - guile: add support of Guile 2.2, disable /guile eval (issue NixOS#1098)
    - python: add detection of Python 3.8

[1] https://weechat.org/files/changelog/ChangeLog-2.7.html
Lassulus
Lassulus approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, works fine

@lheckemann lheckemann merged commit 963e635 into NixOS:master Dec 10, 2019
@mweinelt mweinelt deleted the weechat_2.7 branch December 10, 2019 13:25
@eli-schwartz
Copy link

Incidentally, php and javascript aren't "suddenly enabled by default". This hit archlinux too, and the actual cause is weechat/weechat@bff40e4 which caused optional dependencies which are switched on by default, to raise a fatal error instead of being disabled if their required build dependencies are missing.

You can go take a look here to see whether the two *.js scripts and completely nonexistent *.php scripts are worth supporting. https://weechat.org/scripts/stable/sort/language/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@Lassulus Lassulus Lassulus approved these changes

@the-kenny the-kenny Awaiting requested review from the-kenny

@lovek323 lovek323 Awaiting requested review from lovek323

@Ma27 Ma27 Awaiting requested review from Ma27

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mweinelt @eli-schwartz @marsam @Lassulus @lheckemann