Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmh: init at 0.4 #75312

Merged
merged 2 commits into from Mar 14, 2020
Merged

mmh: init at 0.4 #75312

merged 2 commits into from Mar 14, 2020

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Dec 8, 2019

New package for mail reader I use for long time. Patches are ported from
Debian package (also mine).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc grahamc changed the title ###### Motivation for this change mmh: init at 0.4 Dec 8, 2019
@KAction
Copy link
Contributor Author

KAction commented Mar 13, 2020 •
edited

@veprbl Update:

  1. packaged git snapshot (mmh-0.4 -> mmh-unstable-2019-09-08)
  2. dropped all patches
  3. marked as broken on darwin (I take your word, but where do I see it myself?)
  4. updated key in maintainers list

@veprbl
Copy link
Member

veprbl commented Mar 13, 2020

@GrahamcOfBorg build mmh

@alyssais
Copy link
Member

Can you add some gaps between lines for readability? Have a look at some other packages to see how we usually group things.

@KAction
Copy link
Contributor Author

KAction commented Mar 14, 2020

@alyssais Done.

doronbehar
doronbehar reviewed Mar 14, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few styling comments.

pkgs/applications/networking/mailreaders/mmh/default.nix
@@ -0,0 +1,24 @@
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:
let rev = "431604647f89d5aac7b199a7883e98e56e4ccf9e";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To put my 2 cents, I prefer to not use a let-in for such a trivial variable, so I'd just put it straight in src. Moreover, Although their git server is slow, I'd use fetchgit never the less. 1 example of an advantage to that is that It'll be easier to switch to a different git server if fetchgit is used. It's also possible that in the future all derivations with sources using fetchgit, will be automatically updated once a new tag was set. There are plans for making our main updater bot @r-ryantm do that.

pkgs/applications/networking/mailreaders/mmh/default.nix
@@ -0,0 +1,24 @@
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continuing from @alyssais 's comment,

Suggested change
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:

Personally, I prefer:

Suggested change
{ stdenv, fetchurl, ncurses, autoreconfHook, flex }:
{ stdenv
, fetchurl
, ncurses
, autoreconfHook
, flex
}:

With this ^, diffs look much better if dependencies are changed.

@veprbl
Copy link
Member

veprbl commented Mar 14, 2020

@GrahamcOfBorg build mmh

@veprbl
Copy link
Member

veprbl commented Mar 14, 2020

I think, we need to cut the review process here.

@veprbl veprbl merged commit 2547ef9 into NixOS:master Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KAction @veprbl @alyssais @doronbehar