libosmium: 2.15.3 -> 2.15.4 #75271
Merged
libosmium: 2.15.3 -> 2.15.4 #75271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
das-g
approved these changes
Dec 8, 2019
There was a problem hiding this comment.
Diff LGTM.
Tests done:
-
nix-review pr 75271
Then, in the resulting shell:
- checked what's being tested
nix run nixpkgs.tree -c tree results/
results/ ├── libosmium -> /nix/store/z6gf1indcbd2ad1w0xbli2la7pksm6jl-libosmium-2.15.4 └── osmium-tool -> /nix/store/4rzwxk25hghd46d2l3gkn384bmaav4l9-osmium-tool-1.11.1 2 directories, 0 filesnix run nixpkgs.tree -c tree results/osmium-tool
results/osmium-tool └── bin └── osmium 1 directory, 1 file - smoke-tested the included binary:
-
osmium --version
osmium version 1.11.1 libosmium version 2.15.4 Copyright (C) 2013-2019 Jochen Topf <jochen@topf.org> License: GNU GENERAL PUBLIC LICENSE Version 3 <https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. ``` -
(output looked sensible and identical to that produced with
osmium fileinfo $SOME_PBF_FILE680hmhvlzzyxkl7ch1i7f4c3y4lh81f7-osmium-tool-1.10.0currently included in NixOS 19.03)
-
Ship it! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libosmium/versions.
meta.description for libosmium is: '"Fast and flexible C++ library for working with OpenStreetMap data"'.
meta.homepage for libosmium is: '"https://osmcode.org/libosmium/"
Release on GitHub
Compare changes on GitHub
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 2.15.4 with grep in /nix/store/z6gf1indcbd2ad1w0xbli2la7pksm6jl-libosmium-2.15.4
directory tree listing: https://gist.github.com/f9b2e08541df4b7da7169019ea7d6355
du listing: https://gist.github.com/7ddf59ad62b63b603535525be8edc899
Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)
2 package rebuild(s)
2 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
libosmium
osmium-tool
Instructions to test this update (click to expand)
Either download from Cachix:
(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
cc @das-g for testing.