Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rambox-pro: fix missing icons, autostart and clean up dir layout #75269

Merged
merged 2 commits into from May 20, 2020
Merged

rambox-pro: fix missing icons, autostart and clean up dir layout #75269

merged 2 commits into from May 20, 2020

Conversation

cawilliamson
Copy link
Member

@cawilliamson cawilliamson commented Dec 8, 2019

Motivation for this change

The main motivation for this change was to add actual icons to Rambox Pro since the lack of any icons was bugging me and no doubt any other users of the package.

I have also resolved an issue where the Electron application itself was autostarted at login instead of Rambox Pro like it should be.

I also decided to clean up the directory structure in-line with other similar packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cawilliamson cawilliamson changed the title rambox-pro: fix missing icons and clean up dir layout rambox-pro: fix missing icons, autostart and clean up dir layout Dec 8, 2019
@cawilliamson
Copy link
Member Author

Once this changeset is merged - I'll push an update to v1.2.1.

@ghost
Copy link

ghost commented May 20, 2020

cc @cawilliamson

@Mic92
Copy link
Member

Mic92 commented May 20, 2020

Result of nixpkgs-review pr 75269 1

1 package built:
- rambox-pro

@Mic92 Mic92 merged commit 7182b94 into NixOS:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants