Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pantheon: use GTK3_MODULES #75319

Merged
merged 1 commit into from Dec 9, 2019
Merged

nixos/pantheon: use GTK3_MODULES #75319

merged 1 commit into from Dec 9, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #75244

See also elementary/default-settings#150.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jtojnar
jtojnar approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@worldofpeace worldofpeace merged commit f9246ba into NixOS:master Dec 9, 2019
@worldofpeace worldofpeace deleted the pantheon-gtk3-modules branch December 9, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GTK pantheon-filechooser-module cannot be loaded
2 participants
@worldofpeace @jtojnar